fix(localenv): C9 MASE fail to start #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
mkurapov
reviewed
Jun 25, 2024
| @@ -72,7 +72,7 @@ services: | |||
| EXCHANGE_RATES_URL: http://cloud-nine-wallet/rates | |||
| REDIS_URL: redis://shared-redis:6379/0 | |||
| WALLET_ADDRESS_URL: ${CLOUD_NINE_WALLET_ADDRESS_URL:-https://cloud-nine-wallet-backend/.well-known/pay} | |||
| ILP_CONNECTOR_URL: ${CLOUD_NINE_CONNECTOR_URL} | |||
| ILP_CONNECTOR_URL: ${CLOUD_NINE_CONNECTOR_URL:-http://127.0.0.1:3002} | |||
There was a problem hiding this comment.
Suggested change
| ILP_CONNECTOR_URL: ${CLOUD_NINE_CONNECTOR_URL:-http://127.0.0.1:3002} | |
| ILP_CONNECTOR_URL: ${CLOUD_NINE_CONNECTOR_URL:-http://cloud-nine-wallet-backend:3002} |
Same goes for happy life bank docker compose file, we should use http://happy-life-bank-backend:3002 there.
ILP_CONNECTOR_URL is the one that gets communicated during auto-peering (its basically the URL the fellow peer needs to save in their DB to know where to send packets)
There was a problem hiding this comment.
there were a few more places to make that change as well. updated here 7f3d0a8
mkurapov
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
im seeing the c9 MASE fail to start in the local environment since commit d5c7860
Looks like its from no longer having a default value for the
ILP_CONNECTOR_ADDRESSin backend - setting a default in the docker compose fixes it.Checklist
fixes #number